How old is your brother? I take it you're in the US? I'm in Australia so I can't really give any guidance for what opportunities might be available outside here.

My understanding is that, yes, learning Braille when you still have sight is easier. I'm learning it myself now (I'm 29, I have no idea how much longer I'll have usable vision for. I've lost a level of acuity every year for the past 3 now though).

I assume he has had mobility training, knows how to use a cane etc?

I'm not really sure what else, general life skills are general life skills, you will do what you need to account for the sight you have.

What does he enjoy doing? What are some of the things he'd like to do?

Hey there. I was diagnosed with the same thing about a year ago, it was utterly heart shattering. Honestly, the best thing you can do is stick with your friends and family, and stick to your faith (if you have one). Always keep your head up, and you will be a potential inspiration to everyone you know! Keep on keeping on <3

Don't give up hope! It may take a while for him to fully accept his vision loss, but with proper rehabilitation and an open mind, he can live a fulfilling life. What sorts of things is he interested in?

Yes, it is easier to learn Braille when having some vision. One of my coworkers used to have Braille lessons with a client, who would drive home afterwards. Most of the learning is a bit easier with some vision (doesn't mean it isn't possible with no vision, may just take a little longer).

If he is bumping into things (chairs and walls impacting his knees or shoulders), or having falls (from tripping on steps and such), he should definitely consider getting some orientation and mobility training. Depending on where he is from, contact your local vision loss rehabilitation agency for an assessment.

It might take some time to adjust for $1 and that's alright. Most people tend to get depressed when experiencing such changes. As artificial intelligence advances, $1 help people to regain confidence. This tiny camera attachment can assist your brother to have a smoother transition to his new life. You can offer him to get comfortable with one of this devices so he can achieve increased independence. At least this is what helped my cousin during a similar process.

I recall when this came up previously that someone mentioned there was an intensive education program for learning skills while still sighted, and the benefit was dramatic (relative to waiting until after). I'm not sure how I'd dig it up again, but it was probably discussed in this sub.

Also stumbled on this while trying to find it:
https://books.google.ca/books?id=_hIVd64wpCsC&pg=PA61&lpg=PA61&dq=training+before+losing+sight&source=bl&ots=Ew3wT-54TC&sig=yRl_0l5_W6isBwTqT0y6zcZL1F8&hl=en&sa=X&ved=0ahUKEwir15uhjovYAhWL64MKHRJmDfs4ChDoAQhbMAk#v=onepage&q=training%20before%20losing%20sight&f=false

but haven't read it.

He should meet some success for blind people that are his age